Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Clean connectors before custom query rule test #147921

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Dec 21, 2022

Summary

Connector list is not cleaned up currently which prevents running custom_query_rule.cy.ts more than once after bootstrap (manually from the cypress UI). This PR ensures that the connector list is cleaned up properly.

Checklist

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.7.0 labels Dec 21, 2022
@lgestc lgestc requested review from a team as code owners December 21, 2022 14:11
@lgestc lgestc requested a review from maximpn December 21, 2022 14:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 439 445 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 515 521 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules Area LGTM

@lgmys thanks for the improvement!

I'm curious though if this issue happens in the other test files. If that's the case it would be nice to fix for all rule types.

@lgestc lgestc merged commit 2a02b23 into main Dec 21, 2022
@lgestc lgestc deleted the custom_query_e2e_suite_improvements branch December 21, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants