[Response Ops] [Alerting] Unflattening summarized alerts #147890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
changed the title
ymao1
added
Feature:Alerting
Team:ResponseOps
ymao1
force-pushed
the
alerting/summary-alert-format
branch
from
60d23ea to
78c2c07
Compare
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ersin-erdal
reviewed
Dec 21, 2022
|
|
||
| const expandFlattenedAlert = (alert: object) => { | ||
| if (Array.isArray(alert)) { | ||
| return alert; |
There was a problem hiding this comment.
Could an alert-as-data record be an array?
I though it's always like:
{
'kibana.alert.id':'5'
'kibana.alert.name':'name'
}
There was a problem hiding this comment.
Probably not. I took this from detection rules library functions 🙈. I can remove the check
There was a problem hiding this comment.
I was going to check how security solutions did it :)
…g/summary-alert-format
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ymao1 |
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Dec 22, 2022
) Towards elastic#147379 ## Summary When investigating how to [onboard detection alerts onto framework alert summaries](elastic#147379), there were some discrepancies in the format of the alert documents returned. This PR fixes the formatting so it matches and there will be no difference in `context.alerts` when we migrate detection alerts to the framework. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #147379
Summary
When investigating how to onboard detection alerts onto framework alert summaries, there were some discrepancies in the format of the alert documents returned. This PR fixes the formatting so it matches and there will be no difference in
context.alertswhen we migrate detection alerts to the framework.Checklist