Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v72.0.0 #147888

Merged
merged 7 commits into from
Dec 22, 2022
Merged

Upgrade EUI to v72.0.0 #147888

merged 7 commits into from
Dec 22, 2022

Conversation

cee-chen
Copy link
Contributor

Summary

[email protected] ⏩ [email protected]

72.0.0

  • Added the customQuickSelectRender render prop to EuiSuperDatePicker, which allows customizing the Quick Select popover (#6382)
  • EuiFilePicker styles have been updated to look more like an interactive element. (#6479)
  • Added a third argument to EuiSelectable's onChange callback. The single option object that triggered the onChange event is now also passed to consumers with its most recent checked state (#6487)

Bug fixes

  • EuiTabs now passes size and expand to all children using a React context provider. (#6478)
  • Fixed security warnings caused by [email protected] sub-dependency (#6482)

Breaking changes

  • Removed size and expand props from EuiTab (#6478)

71.1.0

Deprecations

  • Renamed EuiPageSideBarProps to EuiPageSideBarProps_Deprecated, to reduce usage/confusion with EuiPageSidebar (#6468)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting v8.7.0 labels Dec 20, 2022
@cee-chen cee-chen marked this pull request as ready for review December 20, 2022 21:42
@cee-chen cee-chen requested review from a team as code owners December 20, 2022 21:42
jbudz
jbudz reviewed Dec 20, 2022
View reviewed changes
yarn.lock Show resolved Hide resolved
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Dec 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

TinaHeiligers
TinaHeiligers approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

justinkambic
justinkambic approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime change LGTM

sabarasaba
sabarasaba approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/platform-deployment-management changes lgtm

stratoula
stratoula approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visualzations team changes LGTM

sebelga
sebelga approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

1Copenut
1Copenut approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! I traced the deprecated props and test changes so I knew what to focus on. Spot checked the sidebar in a local instance.

@cee-chen
Copy link
Contributor Author

@elasticmachine merge upstream

@cee-chen
Copy link
Contributor Author

@elastic/security-solution Pinging y'all as the last CODEOWNER request! We'll be asking Kibana Ops to admin merge if we don't hear back/receive a review by EOD.

Happy holidays all!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 518 568 +50

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 349.8KB 378.5KB +28.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 390.9KB 391.0KB +132.0B
kbnUiSharedDeps-css 324.3KB 324.0KB -250.0B
kbnUiSharedDeps-npmDll 5.3MB 5.3MB -507.0B
total -625.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 436 442 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 512 518 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 251bdce into elastic:main Dec 22, 2022
@cee-chen cee-chen deleted the eui-v72.x branch December 22, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

@justinkambic justinkambic justinkambic approved these changes

@stratoula stratoula stratoula approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@jbudz jbudz jbudz approved these changes

@sebelga sebelga sebelga approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@1Copenut 1Copenut 1Copenut approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.