Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Portable Dashboards] Implementation Feature Branch (#144332)" #147639

Closed
wants to merge 1 commit into from

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 15, 2022

This reverts commit f3af8e0.

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #4 / Add endpoint exception from rule details allows user to search for items

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 352 357 +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 109 114 +5
presentationUtil 174 171 -3
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 454.3KB 454.3KB +13.0B
dashboard 368.1KB 404.2KB +36.1KB
ml 3.4MB 3.4MB +48.0B
presentationUtil 130.4KB 130.7KB +318.0B
securitySolution 10.1MB 10.1MB +8.0B
total +36.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dashboard 2 3 +1
presentationUtil 11 12 +1
total +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
controls 32.5KB 32.5KB -1.0B
dashboard 25.3KB 41.3KB +16.1KB
dashboardEnhanced 15.1KB 15.2KB +24.0B
embeddable 69.8KB 69.7KB -151.0B
presentationUtil 40.8KB 40.7KB -103.0B
total +15.8KB
Unknown metric groups

API count

id before after diff
dashboard 113 121 +8
embeddable 514 513 -1
presentationUtil 230 227 -3
total +4

async chunk count

id before after diff
dashboard 8 7 -1

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
dashboard 6 7 +1
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 440 446 +6
total +21

Total ESLint disabled count

id before after diff
dashboard 6 7 +1
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 517 523 +6
total +22

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants