[Visualize] Fixes the case with existing saved search and absent dataview

[stratoula]

Summary

Closes #147285

It fixes the bug that is described in the issue. If you create a saved search with an index pattern and then delete the index pattern. now it won't break the entire kibana but will navigate to to the following screen that indicates that there is no index.

This is an edge case on my point of view, ideally if there are saved searches that correspond to a non-existent dataview should not be on the list but the current architecture doesn't allow to quickly solve this. I think it is fine for now.

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 93b0c5d

Failed CI Steps

• FTR Configs #43

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visDefaultEditor	142.3KB	142.5KB	+176.0B
visTypeXy	40.5KB	40.7KB	+236.0B
total			+412.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	60	66	+6
osquery	109	115	+6
securitySolution	445	451	+6
total			+20

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	69	75	+6
osquery	110	117	+7
securitySolution	521	527	+6
total			+21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

[dej611]

Tested on Safari, but I have few questions.

I can see the new error only when creating a new visualization with a saved search referencing a missing dataView.

Also, why do I see two toasts?

When opening a visualization referencing a saved search, which points to a missing dataView things get a little bit more confusing:

• on dashboard it looks like the saved search object is missing, but it's not

• also opening the editor (via dashboard link, or via Visualize library) it seems like the saved search object cannot be found:

[stratoula]

@dej611 this Pr fixes the bug as described in the issue: Remove an index pattern from an existing saved search for a new visualization.

For existing visualizations, this is how it worked. I agree that is not the best UX but this is how it works on main. We can create an enhancement request to improve the behavior.

About the toasts I also think that it should be investigated on another PR as this happens in general. (multiple toasts creation) My goal here is to not break kibana.