-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Explore Sub Plugin Part 1- Consolidate into Explore Directory #147298
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Files by Code Ownerelastic/awp-viz
elastic/security-detections-response-rules
elastic/security-solution
elastic/security-threat-hunting-explore
elastic/security-threat-hunting-investigations
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awp lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for Detection Rule changes 👍.
Only change was to rule_details/index.tsx
, which was an update to an import that now lives within the explore
sub-dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to only move the code in this PR. 👏 👏
I haven't checked each file (522 😰), but I tested it locally and couldn't find issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm
This is part 1 of the work described here. In this PR, explore code was moved only. Creating the explore sub plugin will be part 2 (draft PR, will reopen against
main
once this PR is merged).Consolidate into explore directory
1. The following directories have been moved within
public/explore
:public/hosts
=>public/explore/hosts
public/network
=>public/explore/network
public/users
=>public/explore/users
2. components/containers that are solely or primarily being consumed by files within the new explore directory above
public/explore/components
/public/explore/containers
:public/common/components/authentications
=>public/explore/components/authentications
public/common/containers/authentications
=>public/explore/containers/authentications
public/common/components/paginated_table
=>public/explore/components/paginated_table
public/common/components/stat_items
=>public/explore/components/stat_items
public/risk_score
=>public/explore/components/risk_score
/public/explore/containers/risk_score
public/common/components/severity
=>public/explore/components/risk_score/severity
public/common/components/top_risk_score_contributers
=>public/explore/components/risk_score/top_risk_score_contributers
3.
CODEOWNERS
file updated to reflect these changes4. Consolidate the 3
jest.config.js
files into one underpublic/explore/jest.config.js