-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] show dataset combo box for input packages #147015
Conversation
Pinging @elastic/fleet (Team:Fleet) |
id="xpack.fleet.createPackagePolicy.stepConfigure.inputVarFieldOptionalLabel" | ||
defaultMessage="Optional" | ||
if (name === 'data_stream.dataset' && packageType === 'input') { | ||
return <DatasetComboBox datasets={datasets} value={value} onChange={onChange} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only real change here, look without whitespace
}, | ||
]); | ||
|
||
if (!value) onChange(defaultOption); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wrap this an useEffect
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Closes #145903
Added datasets combo box to input type packages
Dataset name
variable with the option of creating a new one.Using the existing
/data_streams
API to show the list of all datasets.Package policy create/edit API already supports setting the value of
data_stream.dataset
(input packages should have this variable as described in #133296)To verify:
Custom Logs
integrationAdded ordering of datasets to move up those that start with the package name e.g.
system*
datasets come first if adding asystem
integration. Other than that ordering datasets alphabetically.The rest of the requirements seem to be already implemented, see comments
Checklist