Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search][ML Inference] migrate add inference pipeline from modal to flyout #146924

Merged
merged 3 commits into from
Dec 12, 2022
Merged

[Enterprise Search][ML Inference] migrate add inference pipeline from modal to flyout #146924

merged 3 commits into from
Dec 12, 2022

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Dec 2, 2022 •
edited by kibanamachine
Loading

Summary

Moved the Add inference pipeline from a modal to a flyout to improve the UX and follow our own design guidelines.

Screenshots

Configure:
image
Test:
image
Review:
image

No Models:
image

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.7.0 labels Dec 2, 2022
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner December 2, 2022 21:09
@TattdCodeMonkey TattdCodeMonkey requested a review from a team December 2, 2022 21:09
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/inference-pipeline-flyout branch from 0f82abc to 61e5be4 Compare December 5, 2022 15:19
zombieFox
zombieFox approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@zombieFox zombieFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've got some additional layout request but they may be out of scope of this work (Slack discussion). Feel free to include it or not. Otherwise good to go.

@TattdCodeMonkey
migrate add inference pipeline from modal to flyout
89e67ff 
Moved the Add inference pipeline from a modal to a flyout to improve the
UX and follow our own design guidelines.
@TattdCodeMonkey
use flyout size instead of style width
275d2fb
@TattdCodeMonkey
ml-inference: clean-up review step layout
f81675c
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/inference-pipeline-flyout branch from 0cbfb26 to f81675c Compare December 12, 2022 20:42
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.0MB 2.0MB +56.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

  • 💚 Build #92856 succeeded 0cbfb26119aab4333a93ce30df36ed3dd5601e53
  • 💛 Build #92735 was flaky 61e5be46f03def328bdddf060662189e13ff55ea
  • 💔 Build #92461 failed 0f82abc2fc458eb1555eef078c341ca07dec6d51

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit 942eec0 into elastic:main Dec 12, 2022
@kibanamachine kibanamachine mentioned this pull request Dec 12, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 12, 2022
@TattdCodeMonkey
[Enterprise Search][ML Inference] migrate add inference pipeline from…
049dad7 
… modal to flyout (elastic#146924)

## Summary

Moved the Add inference pipeline from a modal to a flyout to improve the
UX and follow our own design guidelines.

### Screenshots
Configure:
<img width="1433" alt="image"
src="https://user-images.githubusercontent.com/1972968/205386204-0e1c605b-3fcb-4f2f-9665-6b46c9bd39fc.png">
Test:
<img width="1433" alt="image"
src="https://user-images.githubusercontent.com/1972968/205386273-85f17deb-b321-4a9e-9c04-5871c316cf81.png">
Review:
<img width="1433" alt="image"
src="https://user-images.githubusercontent.com/1972968/205386305-1861f699-e65e-4531-9820-41f4362a4b4e.png">

No Models:
<img width="1433" alt="image"
src="https://user-images.githubusercontent.com/1972968/205386430-889f726f-5eea-48b1-94f5-921193ca3adc.png">

(cherry picked from commit 942eec0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 13, 2022
@kibanamachine @TattdCodeMonkey
[8.6] [Enterprise Search][ML Inference] migrate add inference pipelin…
952ad51 
…e from modal to flyout (#146924) (#147402)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Enterprise Search][ML Inference] migrate add inference pipeline from
modal to flyout
(#146924)](#146924)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-12T23:28:21Z","message":"[Enterprise
Search][ML Inference] migrate add inference pipeline from modal to
flyout (#146924)\n\n## Summary\r\n\r\nMoved the Add inference pipeline
from a modal to a flyout to improve the\r\nUX and follow our own design
guidelines.\r\n\r\n\r\n### Screenshots\r\nConfigure:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386204-0e1c605b-3fcb-4f2f-9665-6b46c9bd39fc.png\">\r\nTest:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386273-85f17deb-b321-4a9e-9c04-5871c316cf81.png\">\r\nReview:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386305-1861f699-e65e-4531-9820-41f4362a4b4e.png\">\r\n\r\nNo
Models:\r\n<img width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386430-889f726f-5eea-48b1-94f5-921193ca3adc.png\">","sha":"942eec07fa30e17ed510468d90bde9c03c3908fa","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.6.0","v8.7.0"],"number":146924,"url":"https://github.com/elastic/kibana/pull/146924","mergeCommit":{"message":"[Enterprise
Search][ML Inference] migrate add inference pipeline from modal to
flyout (#146924)\n\n## Summary\r\n\r\nMoved the Add inference pipeline
from a modal to a flyout to improve the\r\nUX and follow our own design
guidelines.\r\n\r\n\r\n### Screenshots\r\nConfigure:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386204-0e1c605b-3fcb-4f2f-9665-6b46c9bd39fc.png\">\r\nTest:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386273-85f17deb-b321-4a9e-9c04-5871c316cf81.png\">\r\nReview:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386305-1861f699-e65e-4531-9820-41f4362a4b4e.png\">\r\n\r\nNo
Models:\r\n<img width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386430-889f726f-5eea-48b1-94f5-921193ca3adc.png\">","sha":"942eec07fa30e17ed510468d90bde9c03c3908fa"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146924","number":146924,"mergeCommit":{"message":"[Enterprise
Search][ML Inference] migrate add inference pipeline from modal to
flyout (#146924)\n\n## Summary\r\n\r\nMoved the Add inference pipeline
from a modal to a flyout to improve the\r\nUX and follow our own design
guidelines.\r\n\r\n\r\n### Screenshots\r\nConfigure:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386204-0e1c605b-3fcb-4f2f-9665-6b46c9bd39fc.png\">\r\nTest:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386273-85f17deb-b321-4a9e-9c04-5871c316cf81.png\">\r\nReview:\r\n<img
width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386305-1861f699-e65e-4531-9820-41f4362a4b4e.png\">\r\n\r\nNo
Models:\r\n<img width=\"1433\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/1972968/205386430-889f726f-5eea-48b1-94f5-921193ca3adc.png\">","sha":"942eec07fa30e17ed510468d90bde9c03c3908fa"}}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieFox zombieFox zombieFox approved these changes

@efegurkan efegurkan efegurkan approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TattdCodeMonkey @kibana-ci @kibanamachine @efegurkan @zombieFox