-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Bulk edit assignees #146907
[Cases] Bulk edit assignees #146907
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
d676ef6
to
9bf0b69
Compare
@elasticmachine merge upstream |
Without the suggestions functionality, I don't think it is very obvious that you have to start typing something to see a list of users you can assign a case to. And here it looks like all I can do is remove the currently assigned user. It would be nice if we could get the same UX as from the View case page, where you see a list of users before typing anything: If that isn't possible, I think we need some help text on the flyout, saying something like Any thoughts @mdefazio ? |
x-pack/plugins/cases/public/components/actions/assignees/edit_assignees_selectable.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/actions/assignees/edit_assignees_selectable.test.tsx
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/actions/assignees/edit_assignees_selectable.test.tsx
Show resolved
Hide resolved
@mdefazio We discuss it with @peteharverson offline and we decide to not do any changes expect improving labels, search placeholders, and adding a message when the selected assignees do not have any assignees. We can improve it later when we introduce suggestions. |
I am having some weird behavior with the suggested users: Screen.Recording.2022-12-15.at.16.11.09.movAdditionally, is this expected? Screen.Recording.2022-12-15.at.16.15.35.movFind it a bit weird that if I clear the search and we display |
x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx
Outdated
Show resolved
Hide resolved
@peteharverson I update the placeholder text and show a message when there are no assignees in the selected cases. I also added the "Remove all assignees" functionality. @adcoelho For the first scenario, this also happens in the popover on the view case page. It is happening because if the search results are already added in the selectable the EUI will perform a search in the list as you type. In the meanwhile, we are fetching new results based on what you typed. ES searches differently and does not return the same. I can explain better offline if you like. If you think it is a bug we should fix could you please open an issue so we can fix it on another PR? For the second scenario, yes it is expected. Same as the tags, from the initial assignees you need to know which are the one you are removing. |
x-pack/plugins/cases/public/components/actions/assignees/translations.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and other than one minor comment, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM. Amazing work 🚀
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @cnasikas |
Summary
This PR adds the ability to bulk edit assignees on multiple cases. Because the tags and the assignees share common logic:
useIsUserTyping
hook which contains common logic for when the user is typing. Is meant to be used with debouncing functionsuseItemsAction
anduseItemsState
. No logic was changed in the state managementbulk_edit_assignees.mov
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release notes
Add the ability to bulk edit assignees on multiple cases