-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Change term sorting to match Kibana Core #14679
Conversation
@monicasarbu This concerns you too :D |
@simianhacker woah, big change! While I agree that it is a huge source of confusion for users and am happy we're addressing it, I also believe that having the ability to show the most recent value is one of the stronger features of TSVB. Especially for operational monitoring use case. Will we still allow the option to report on the last full or partial bucket for a series? Or are we completely removing it? Also, how does this affect things like overall aggregations? Are they still useful? Maybe we can sync offline here, I'd just like to understand the impact a bit more. |
@alexfrancoeur This only affects the order of the terms returned when doing a group by, everything else remains unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexfrancoeur Any objections? I'm ready to merge this. |
@simianhacker LGTM as well, no objections. I think we'll need to make sure #14798 is completed soon to reiterate what it means to be experimental. This will likely affect visualizations in production. @monicasarbu any objections on the beats side for modules? |
Hey, any update on this? |
* [TSVB] Change term sorting to make Kibana Core * removing last bucket changes * Update tests to reflect new sorting metric
Back ported to 6.x with 0b3de29 |
This PR changes the way TSVB sorts terms aggs to use the entire time range instead of the last bucket. For example, let say you're looking at the last 15 minutes, if you create a series where the metric is "average of system.cpu.user.pct" and set the interval to auto, TSVB currently will calculate the bucket size to be 10 seconds and then create a filter aggregation with a range that encapsulates the last 10 seconds of the time period along with the metric above and sort on the result. With this PR that filter aggregation (with the range) is removed and instead will sort on the average of system.cpu.user.pct for the entire time range (basically averaging all the buckets together).
This will make the results for basic aggregations in TSVB and Kibana Core match. This has been a source of confusion for a few users.
Thoughts? @alexfrancoeur @tbragin @rashidkpc