Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Kill es in finally #146680

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[Patch] Kill es in finally #146680

merged 1 commit into from
Nov 30, 2022

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Nov 30, 2022

Summary

Patch for #146605
Currently if a test fails, ES is not killed, causing errors for all following tests

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes Team:Performance v8.7.0 labels Nov 30, 2022
@lizozom lizozom requested a review from a team as a code owner November 30, 2022 12:46
@lizozom lizozom self-assigned this Nov 30, 2022
@dmlemeshko dmlemeshko requested review from dmlemeshko and a team November 30, 2022 12:59
@lizozom lizozom enabled auto-merge (squash) November 30, 2022 12:59
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

@lizozom lizozom merged commit 8cde378 into elastic:main Nov 30, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Performance v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants