[Security Solution] Refactors All exception lists - read only tests to remove flakiness
#146677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 30, 2022
… to remove flakiness (elastic#146677) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 8a6cc0c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 30, 2022
… tests to remove flakiness (#146677) (#146708) # Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution] Refactors `All exception lists - read only` tests to remove flakiness (#146677)](#146677) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gloria Hornero","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-30T15:41:44Z","message":"[Security Solution] Refactors `All exception lists - read only` tests to remove flakiness (#146677)\n\nCo-authored-by: Kibana Machine <[email protected]>","sha":"8a6cc0cd26425afa67a448ffadc4de15f82d208d","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team:Security Solution Platform","v8.6.0","v8.7.0"],"number":146677,"url":"https://github.com/elastic/kibana/pull/146677","mergeCommit":{"message":"[Security Solution] Refactors `All exception lists - read only` tests to remove flakiness (#146677)\n\nCo-authored-by: Kibana Machine <[email protected]>","sha":"8a6cc0cd26425afa67a448ffadc4de15f82d208d"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146677","number":146677,"mergeCommit":{"message":"[Security Solution] Refactors `All exception lists - read only` tests to remove flakiness (#146677)\n\nCo-authored-by: Kibana Machine <[email protected]>","sha":"8a6cc0cd26425afa67a448ffadc4de15f82d208d"}}]}] BACKPORT--> Co-authored-by: Gloria Hornero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The aim of this PR is to remove the flakiness on the
All exception lists - read onlyCypress tests.Yesterday we've seen these tests failing a lot on different PRs, in order to make the tests more robust, this is the list of changes that have been implemented:
esArchiverResetKibanaforcleanKibanasince the cleaning the second method does is more extensive than the first one.beforehook code to abeforeEach. We use the Cypress test retries capability, this only reexecute the code inside the beforeEach hook not the one on thebefore.beforeEachhook, now before creating the exception list, we make sure the list is deleted before taking the action.All the above modifications should have made the test more reliable.