Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix wide button sizes in ml callout #146571

Merged
merged 1 commit into from
Nov 29, 2022
Merged

[APM] Fix wide button sizes in ml callout #146571

merged 1 commit into from
Nov 29, 2022

Conversation

kpatticha
Copy link
Contributor

Summary

closes: #145870

Before
image

After
image

@kpatticha kpatticha requested a review from a team as a code owner November 29, 2022 15:51
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Nov 29, 2022
yngrdyn
yngrdyn approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍫

@kpatticha kpatticha enabled auto-merge (squash) November 29, 2022 16:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +31.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 36808ec into elastic:main Nov 29, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Milestone
No milestone
5 participants
@kpatticha @elasticmachine @kibana-ci @yngrdyn @kibanamachine