[Canvas] Fix expression editor test

[nickpeihl]

Fixes a skipped flaky test for the expression editor.

The test was skipped before the expression editor was changed to use Monaco in #133318. I refactored the test to use the Monaco service which should also address #133318 (comment).

Flaky test runner

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[ThomThomson]

Awesome to see this test reinstated! Approving this based on the flaky test runner result, but ideally, more than 10 runs is better for flaky test runner, because some flakiness can be pernicious and only fail once every 100ish runs.

Left one nit.

[ThomThomson]

This could introduce some flakiness here, how did you come to the 300 ms number here?

[nickpeihl]

I set 300ms as a sorta arbitrary number. If I'm understanding correctly, the line below sets a 250ms debounce on updates to the sidebar editor before calling the onChange callback. That might be enough time for the expression editor to receive the updates, or I could set this to a larger sleep.

kibana/x-pack/plugins/canvas/canvas_plugin_src/uis/arguments/editor.tsx

Line 85 in 17e51c6

template: templateFromReactComponent(withDebounceArg(EditorArg, 250)),

I'm running a new flaky test job with 100 runs here: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1607. Do you think that is sufficient or maybe try a larger number?

[ThomThomson]

I think 100 runs is definitely sufficient, thank you for doing that! If they all pass, then I'd say that 300ms is long enough to sleep, especially now that I know where the 300ms number comes from.

[nreese]

Instead of sleep, how about putting assert statement below in a retry? That way the functional test is not couple to a debounce value

[nickpeihl]

Instead of sleep, how about putting assert statement below in a retry? That way the functional test is not couple to a debounce value

Ooh, good idea!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 7373d63

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	1.0MB	1.0MB	+82.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
osquery	1	2	+1

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
fleet	59	65	+6
osquery	109	115	+6
securitySolution	442	448	+6
total			+20

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
fleet	68	74	+6
osquery	110	117	+7
securitySolution	519	525	+6
total			+21

History

• 💚 Build #91444 succeeded 17e51c6
• 💔 Build #91191 failed 66503e1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream