[Synthetics] Deprecate adding synthetics integrations from fleet #146369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
florent-leborgne
previously requested changes
Nov 28, 2022
There was a problem hiding this comment.
👋 I've left a few suggestions to tweak the wording in the popup. Feel free to adapt.
-
I would suggest not to add too many links to the docs from this popup. Instead, we could add another empty button next to "Go back" that would be "Learn more" or "Check docs" with a link to https://www.elastic.co/guide/en/observability/current/monitor-uptime-synthetics.html
-
I think we could combine the 2 points about Elastic managed locations and private locations
Let me know what you think and I can suggest different things or do more tweaks.
.../plugins/synthetics/public/legacy_uptime/components/fleet_package/deprecate_notice_modal.tsx
Outdated
Show resolved
Hide resolved
.../plugins/synthetics/public/legacy_uptime/components/fleet_package/deprecate_notice_modal.tsx
Outdated
Show resolved
Hide resolved
.../plugins/synthetics/public/legacy_uptime/components/fleet_package/deprecate_notice_modal.tsx
Outdated
Show resolved
Hide resolved
.../plugins/synthetics/public/legacy_uptime/components/fleet_package/deprecate_notice_modal.tsx
Outdated
Show resolved
Hide resolved
.../plugins/synthetics/public/legacy_uptime/components/fleet_package/deprecate_notice_modal.tsx
Outdated
Show resolved
Hide resolved
…t_package/deprecate_notice_modal.tsx Co-authored-by: florent-leborgne <[email protected]>
…t_package/deprecate_notice_modal.tsx Co-authored-by: florent-leborgne <[email protected]>
…t_package/deprecate_notice_modal.tsx Co-authored-by: florent-leborgne <[email protected]>
…t_package/deprecate_notice_modal.tsx Co-authored-by: florent-leborgne <[email protected]>
…t_package/deprecate_notice_modal.tsx Co-authored-by: florent-leborgne <[email protected]>
|
Updated content after PR feedback
|
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Nov 29, 2022
nchaulet
reviewed
Nov 29, 2022
| docsLink: ( | ||
| <EuiLink | ||
| target="_blank" | ||
| href="https://www.elastic.co/guide/en/observability/current/monitor-uptime-synthetics.html" |
There was a problem hiding this comment.
nit it's probably possible to use the doclink service here to get that link looks like there is already a key for observability.monitorUptimeSynthetics
shahzad31
dismissed
florent-leborgne’s stale review
Took care of all the changes !!!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2022
…stic#146369) Co-authored-by: florent-leborgne <[email protected]> Fixes elastic#137501 (cherry picked from commit d136668)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 30, 2022
#146369) (#146629) # Backport This will backport the following commits from `main` to `8.6`: - [[Synthetics] Deprecate adding synthetics integrations from fleet (#146369)](#146369) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-29T20:29:26Z","message":"[Synthetics] Deprecate adding synthetics integrations from fleet (#146369)\n\nCo-authored-by: florent-leborgne <[email protected]>\r\nFixes https://github.com/elastic/kibana/issues/137501","sha":"d13666885469c354bdb55c7bb84f127d23b1b83f","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","Team:Fleet","v8.6.0","v8.7.0"],"number":146369,"url":"https://github.com/elastic/kibana/pull/146369","mergeCommit":{"message":"[Synthetics] Deprecate adding synthetics integrations from fleet (#146369)\n\nCo-authored-by: florent-leborgne <[email protected]>\r\nFixes https://github.com/elastic/kibana/issues/137501","sha":"d13666885469c354bdb55c7bb84f127d23b1b83f"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146369","number":146369,"mergeCommit":{"message":"[Synthetics] Deprecate adding synthetics integrations from fleet (#146369)\n\nCo-authored-by: florent-leborgne <[email protected]>\r\nFixes https://github.com/elastic/kibana/issues/137501","sha":"d13666885469c354bdb55c7bb84f127d23b1b83f"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #137501
Added a redirect modal when user tries to add synthetics integration from fleet integrations app