-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Set enabled
connector scheduling prop when update crawler scheduling
#146356
[Enterprise Search] Set enabled
connector scheduling prop when update crawler scheduling
#146356
Conversation
…ling for crawler indices
I confirmed that this works on my local machine for me. |
@@ -80,6 +101,9 @@ export const AutomaticCrawlSchedulerLogic = kea< | |||
clearCrawlSchedule: () => DEFAULT_VALUES.crawlFrequency, | |||
setCrawlSchedule: (_, { crawlSchedule: { frequency } }) => frequency, | |||
setCrawlFrequency: (_, { crawlFrequency }) => crawlFrequency, | |||
// TODO Enable this reducer once BE allows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking here and not a strong opinion, but is it necessary to leave these commented-out code blocks in here? Feels to me like this should be documented in an issue somewhere rather than in the code.
setUseConnectorSchedule: actions.saveChanges, | ||
toggleCrawlAutomatically: actions.saveChanges, | ||
submitConnectorSchedule: async ({ scheduling }) => { | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: This try catch block isn't going to do anything, because the makeRequest action always succeeds. Should move the flashErrors to listening to the error action instead.
Closing in favor of #146357 |
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers