Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Set enabled connector scheduling prop when update crawler scheduling #146356

Closed

Conversation

byronhulcher
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@byronhulcher byronhulcher added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 28, 2022
@byronhulcher byronhulcher self-assigned this Nov 28, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 28, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.0MB 2.0MB +369.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

@navarone-feekery
Copy link
Contributor

I confirmed that this works on my local machine for me.

@byronhulcher byronhulcher marked this pull request as ready for review November 28, 2022 12:37
@byronhulcher byronhulcher requested a review from a team November 28, 2022 12:37
@@ -80,6 +101,9 @@ export const AutomaticCrawlSchedulerLogic = kea<
clearCrawlSchedule: () => DEFAULT_VALUES.crawlFrequency,
setCrawlSchedule: (_, { crawlSchedule: { frequency } }) => frequency,
setCrawlFrequency: (_, { crawlFrequency }) => crawlFrequency,
// TODO Enable this reducer once BE allows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking here and not a strong opinion, but is it necessary to leave these commented-out code blocks in here? Feels to me like this should be documented in an issue somewhere rather than in the code.

setUseConnectorSchedule: actions.saveChanges,
toggleCrawlAutomatically: actions.saveChanges,
submitConnectorSchedule: async ({ scheduling }) => {
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: This try catch block isn't going to do anything, because the makeRequest action always succeeds. Should move the flashErrors to listening to the error action instead.

@byronhulcher
Copy link
Contributor Author

Closing in favor of #146357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants