Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Moves the mosaic/waffle charts into GA #146261

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 24, 2022

Summary

Removes the technical preview badge from the mosaic/waffle charts

image

@stratoula stratoula changed the title [Lens] Remove the tehnical preview badge from the mosaic/waffle charts [Lens] Removes the tehnical preview badge from the mosaic/waffle charts Nov 24, 2022
@stratoula stratoula changed the title [Lens] Removes the tehnical preview badge from the mosaic/waffle charts [Lens] Moves the mosaic/waffle charts into GA Nov 24, 2022
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.7.0 labels Nov 24, 2022
@stratoula stratoula marked this pull request as ready for review November 24, 2022 10:47
@stratoula stratoula requested a review from a team as a code owner November 24, 2022 10:47
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stratoula please add a release note so this could appear in the Kibana release note.
Looks something we are interested in showing

@stratoula stratoula added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 24, 2022
@stratoula
Copy link
Contributor Author

Good point! @KOTungseth can you remind me how do we add release notes on the description? We changed it at some point and I can't find the documentation. Is the title sufficient here or do you need something else?

@stratoula
Copy link
Contributor Author

@markov00 we synced with @KOTungseth asynchronously. No need to add release notes here, we will use the title.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB -36.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. I can't see anything that was hiding mosaic/waffle suggestions before, so I guess there's nothing to change there!

@stratoula stratoula merged commit dd0a9dd into elastic:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants