Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6] Upgrade EUI to v67.1.9 #145490

Merged
merged 6 commits into from
Nov 17, 2022
Merged

[8.6] Upgrade EUI to v67.1.9 #145490

merged 6 commits into from
Nov 17, 2022

Conversation

cee-chen
Copy link
Contributor

Summary

[email protected][email protected]

This backport fixes bugs affecting Maps that were found in the latest EUI upgrade (#144845 (comment)). It is meant to go directly into 8.6

67.1.9

  • EuiButton now accepts minWidth={false} (#6373)

Bug fixes

  • Fixed the shadow sizes of .eui-yScrollWithShadows and .eui-xScrollWithShadows (#6374)
  • EuiButton no longer outputs unnecessary inline styles for minWidth={0} or minWidth={false} (#6373)
  • EuiFacetButton no longer reports type issues when passing props accepted by EuiButton (#6373)

@cee-chen cee-chen added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting v8.6.0 labels Nov 17, 2022
@cee-chen
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Alerts timeline Privileges: read only "before each" hook for "should not allow user with read only privileges to attach alerts to a new case"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.1MB 1.1MB -37.0B
maps 2.7MB 2.7MB +24.0B
visTypeVega 1.8MB 1.8MB -37.0B
total -50.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.1MB 5.1MB +39.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review November 17, 2022 20:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@cee-chen cee-chen merged commit fa3a62e into elastic:8.6 Nov 17, 2022
@cee-chen cee-chen deleted the eui-67.1.9 branch November 17, 2022 22:53
@cee-chen cee-chen changed the title Upgrade EUI to v67.1.9 [8.6] Upgrade EUI to v67.1.9 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience EUI release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants