[Renderers] always include baseTheme with charts theme #145401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
Team:Visualizations
drewdaemon
added
the
backport:prev-minor
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
nickofthyme
approved these changes
Nov 16, 2022
src/plugins/chart_expressions/expression_metric/public/components/metric_vis.tsx
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 16, 2022
(cherry picked from commit d82075f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
#145478) # Backport This will backport the following commits from `main` to `8.6`: - [[Renderers] always include baseTheme with charts theme (#145401)](#145401) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-16T23:19:26Z","message":"[Renderers] always include baseTheme with charts theme (#145401)","sha":"d82075f8d6178ecd197be324b75b5eb2d457b746","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.7.0"],"number":145401,"url":"https://github.com/elastic/kibana/pull/145401","mergeCommit":{"message":"[Renderers] always include baseTheme with charts theme (#145401)","sha":"d82075f8d6178ecd197be324b75b5eb2d457b746"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145401","number":145401,"mergeCommit":{"message":"[Renderers] always include baseTheme with charts theme (#145401)","sha":"d82075f8d6178ecd197be324b75b5eb2d457b746"}}]}] BACKPORT--> Co-authored-by: Andrew Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #145308
In accordance with the docs we should always provide both
baseThemeandthemeto theSettingscomponent.Before:
After:
