Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] highlight selected table item #145349

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

orouz
Copy link
Contributor

@orouz orouz commented Nov 16, 2022

this is a quick wins task

this PR updates the latest_findings and resource_findings tables to match the UX of the rules page to highlight selected row and close the flyout when user clicks outside of the flyout.

Screen.Recording.2022-11-16.at.14.14.18.mov

@orouz orouz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related v8.7.0 labels Nov 16, 2022
@orouz orouz requested a review from ari-aviran November 16, 2022 12:20
@orouz orouz requested a review from a team as a code owner November 16, 2022 12:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 128.1KB 128.3KB +268.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@orouz orouz merged commit 4fb9922 into elastic:main Nov 17, 2022
@olegsu
Copy link
Contributor

olegsu commented Feb 14, 2023

I dont have the expend icon, am I doing something wrong?
image

@ari-aviran
Copy link
Contributor

@olegsu you need to click on a resource ID to see all the findings for that specific resource - this is where the fix was

@olegsu
Copy link
Contributor

olegsu commented Feb 16, 2023

Thank you @ari-aviran
Verified
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.7.0 verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants