[6.x] Introduce redux into dashboard (#14518) #14521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
changed the title
* Initial check in of introducing redux in dashboard * Use redux-actions and redux-thunks to reduce boilerplate * Make sure all panels are minimized from the start when a dashboard is loaded - we don't want a panel id from a different dashboard in the state tree on a fresh open. * Remove unused file * use classnames dependency instead of manual logic * First pass on selectors, handleActions, and more segmented reducers. * Fix bugs with selectors and reducers and add tests that would have caught them. * Fix issue plus tests discover was not returning a promise * Make expanding a panel purely a css modification which avoids all re-renders * Found another bug with initial state not being set correctly on a hard refresh * Remove check for change handlers now that the event handler bug is fixed * rename dashboardState => dashboard for reducers and redux state tree * Remove unnecessary top level describe in jest tests * Navigate back to landing page at the end of the newly added test suite * Fix lint errors * Stabilize flaky tests by waiting until saved object search is finished loading results * Don't leak subscriptions to the store. * use selectors to grab dashboard panel off state. * Remove use of getState in dispatcher to avoid circular reference and still use selectors * use spread over object.assign * No need to pass second param in when the input is simply returned as-is.
stacey-gammon
force-pushed
the
backport/6.x/pr-14518
branch
from
24ee1e0 to
6c70e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports pull request #14518 to 6.x