Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Actions] Add rule callback for each rule type #145190

Closed

Conversation

jonathan-buttner
Copy link
Contributor

WIP

This PR expands on #145035 to allow the {{rule.url}} path to point to specific solution's rule details page.

Issue: #145132

@jonathan-buttner jonathan-buttner added enhancement New value added to drive a business result Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework v8.7.0 labels Nov 14, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 14, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/api_integration/config.ts / apis security Privileges GET /api/security/privileges should return a privilege map with all known privileges, without actions
  • [job] [logs] x-pack/test/api_integration/config.ts / apis security Privileges GET /api/security/privileges should return a privilege map with all known privileges, without actions
  • [job] [logs] x-pack/test/api_integration/config.ts / apis security Privileges GET /api/security/privileges?respectLicenseLevel=false should return a privilege map with all known privileges, without actions
  • [job] [logs] x-pack/test/api_integration/config.ts / apis security Privileges GET /api/security/privileges?respectLicenseLevel=false should return a privilege map with all known privileges, without actions
  • [job] [logs] Jest Tests #5 / Execution Handler rule url populates the rule.url in the action params when the base url and alert id are specified
  • [job] [logs] Jest Tests #5 / Execution Handler rule url populates the rule.url in the action params when the base url has a trailing slash and removes the trailing slash
  • [job] [logs] FTR Configs #6 / security (basic license) Privileges GET /api/security/privileges should include sub-feature privileges when respectlicenseLevel is false
  • [job] [logs] FTR Configs #6 / security (basic license) Privileges GET /api/security/privileges should include sub-feature privileges when respectlicenseLevel is false

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1323 1324 +1
cases 511 512 +1
infra 1116 1117 +1
observability 431 432 +1
securitySolution 3285 3286 +1
synthetics 1073 1074 +1
timelines 191 192 +1
triggersActionsUi 461 462 +1
total +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.6MB 9.6MB -32.0B
triggersActionsUi 663.6KB 655.5KB -8.2KB
total -8.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 51.0KB 51.0KB +49.0B
triggersActionsUi 104.0KB 108.1KB +4.1KB
total +4.1KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 53 52 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants