Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided onboarding] Implement search E2E guide #144488

Merged

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Nov 2, 2022

This PR completes the E2E search guide. Changes include adding the manual step completion popover and fixing the search experiences step url.

How to test

  1. This is best to test on cloud. This PR has been deployed there. To reset the guide, use the example plugin and update the step ID to add_data.
  2. Click "Create Elasticsearch index"
  3. Select "Use a connector"
  4. Create an index.
  5. Use Dev Tools to index any document into the created index in step 4.
  6. Step 1 should be marked as complete, and you can finish the guide.

Fixes #138998

JFDtjsehCf.mp4

Screen Shot 2022-11-02 at 7 42 15 PM

@alisonelizabeth alisonelizabeth added release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team ci:cloud-deploy Create or update a Cloud deployment ci:build-example-plugins labels Nov 2, 2022
@alisonelizabeth alisonelizabeth marked this pull request as ready for review November 3, 2022 13:03
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner November 3, 2022 13:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@alisonelizabeth alisonelizabeth added the ui-copy Review of UI copy with docs team is recommended label Nov 3, 2022
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 7, 2022

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 24.7KB 25.2KB +461.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for completing this guide, @alisonelizabeth!
I tested on your Cloud deployment and was able to complete the guide with a web crawler index. I noticed that we have a minor UI issue with the manual completion popover (it should not scroll with the page) and open an issue to track that.

@alisonelizabeth
Copy link
Contributor Author

I'm going to go ahead and merge this so others can start testing the flow. @kellyemurphy if you have any feedback on the copy, I can open up a separate PR.

@alisonelizabeth alisonelizabeth merged commit 0ed0065 into elastic:main Nov 7, 2022
@alisonelizabeth alisonelizabeth deleted the guided_onboarding/search_e2e branch November 7, 2022 20:52
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-example-plugins ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team ui-copy Review of UI copy with docs team is recommended v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Guided onboarding] [Enterprise Search] Implement E2E guided setup flow
5 participants