[6.x] Reactify visualize listing table (#14227) #14447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reactify visualize listing table * refactor toolbar => toolBar * use prompt prop to also cover loading and didn't match search logic. * Use default alignment instead of ternary * Add keys to array elements where missing * Add align property to KuiTableHeaderCell * Fix issue with filter not showing up in search tool bar * onCheckChanged => onSelectionChanged * pagerComponent => pager, actionComponent => actions * use singular verbiage when only 1 item is selected * exit early per style guide * fix lint errors * rename columns => header * Refactor KuiTableHeaderCell into KuiListingTable isChecked => isSelected contents => content refactor KuiTableRowCell internally * fix lint errors * areAllRowsChecked => areAllRowsSelected * improve itemSelectedCount logic in KuiListingTableToolBarFooter * React.Component => Component * make header data a variable, not a function * Only consider all rows selected if rows exist and they are all selected, not if there are no rows. * Adding a few KuiListingTable tests * Give one column sort attributes in examples page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #14227
Reactify visualize listing table
refactor toolbar => toolBar
use prompt prop to also cover loading and didn't match search logic.
Use default alignment instead of ternary
Add keys to array elements where missing
Add align property to KuiTableHeaderCell
Fix issue with filter not showing up in search tool bar
onCheckChanged => onSelectionChanged
pagerComponent => pager, actionComponent => actions
use singular verbiage when only 1 item is selected
exit early per style guide
fix lint errors
rename columns => header
Refactor KuiTableHeaderCell into KuiListingTable
isChecked => isSelected
contents => content
refactor KuiTableRowCell internally
fix lint errors
areAllRowsChecked => areAllRowsSelected
improve itemSelectedCount logic in KuiListingTableToolBarFooter
React.Component => Component
make header data a variable, not a function
Only consider all rows selected if rows exist and they are all selected, not if there are no rows.
Adding a few KuiListingTable tests
Give one column sort attributes in examples page