Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Step details page object count breakdown #144409

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 2, 2022

Summary

Part of #143446

Added object count breakdown !!

image

@shahzad31 shahzad31 changed the title object count [Synthetics] Step details page object count breakdown Nov 2, 2022
@shahzad31 shahzad31 mentioned this pull request Nov 2, 2022
7 tasks
@shahzad31 shahzad31 marked this pull request as ready for review November 2, 2022 13:38
@shahzad31 shahzad31 requested a review from a team as a code owner November 2, 2022 13:38
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Nov 2, 2022
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1005 1006 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.0MB 1.0MB +929.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 103 108 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 104 110 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature works correctly.

👉 Needs more gap as per design. See the below screenshot, it needs more spacing where the red lines are.
image

@shahzad31 shahzad31 merged commit 9e19d09 into elastic:main Nov 3, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 3, 2022
@shahzad31 shahzad31 deleted the object-count branch November 3, 2022 07:52
@dominiqueclarke dominiqueclarke self-assigned this Nov 21, 2022
@dominiqueclarke
Copy link
Contributor

Post FF testing LGTM, but the spacing is still off. Raising a separate ticket.

image

@paulb-elastic
Copy link
Contributor

Linking #145892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants