Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): remove @types/pkg link creation when generating a new package #144200

Merged
merged 1 commit into from
Oct 28, 2022
Merged

chore(NA): remove @types/pkg link creation when generating a new package #144200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/kbn-generate/src/commands/package_command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ ${BAZEL_PACKAGE_DIRS.map((dir) => ` ./${dir}/*\n`).join
throw createFlagError(`package id must start with @kbn/ and have no spaces`);
}

const typePkgName = `@types/${pkgId.slice(1).replace('/', '__')}`;
const web = !!flags.web;
const dev = !!flags.dev;

Expand Down Expand Up @@ -184,12 +183,6 @@ ${BAZEL_PACKAGE_DIRS.map((dir) => ` ./${dir}/*\n`).join
addDeps[pkgId] = `link:bazel-bin/${normalizedRepoRelativeDir}`;
delete removeDeps[pkgId];

// for @types packages always remove from deps and add to devDeps
packageJson.devDependencies[
typePkgName
] = `link:bazel-bin/${normalizedRepoRelativeDir}/npm_module_types`;
delete packageJson.dependencies[typePkgName];

await Fsp.writeFile(packageJsonPath, sortPackageJson(JSON.stringify(packageJson)));
log.info('Updated package.json file');

Expand Down