Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed cardinality agg logic in action_status #144162

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Oct 28, 2022

Summary

Related to #144161

Changed logic in action_status API calculation of agent action acks, to only use cardinality agg if the doc count is less than the precision threshold (40k, this is the max value).

Observed an issue locally that after successful add/remove tags, the ack count didn't reach 50k in action_status response, in this case doc_count was correct, 50k.
So it looks like the cardinality agg can be lower or higher than the actual count.

 {
        "key": "d3b1ef6c-2ed4-4746-ab88-504bf0c4b4c8",
        "doc_count": 50000,
        "max_timestamp": {
          "value": 1666956506014,
          "value_as_string": "2022-10-28T11:28:26.014Z"
        },
        "agent_count": {
          "value": 49874
        }
      }

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 28, 2022
@juliaElastic juliaElastic self-assigned this Oct 28, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner October 28, 2022 11:59
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 4c52d09 into elastic:main Oct 28, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2022
@mistic mistic removed the v8.5.0 label Nov 1, 2022
@mistic
Copy link
Member

mistic commented Nov 1, 2022

Added v8.5.1 tag has the backport for 8.5 didn't make the v8.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants