Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fixed flaky Jest config: x-pack/plugins/security_solution/public/timelines #143824

Merged

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Oct 22, 2022

Resolves #143718

Summary of all failing tests
  | FAIL  x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.test.tsx (193.525 s)
  | ● Body › rendering › it renders a tooltip for timestamp
  |  
  | thrown: "Exceeded timeout of 20000 ms for a test.
  | Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
  |  
  | 192 \|     });
  | 193 \|
  | > 194 \|     test('it renders a tooltip for timestamp', async () => {
  | \|     ^
  | 195 \|       const headersJustTimestamp = defaultHeaders.filter((h) => h.id === '@timestamp');
  | 196 \|       const testProps = { ...props, columnHeaders: headersJustTimestamp };
  | 197 \|       const wrapper = mount(
  |  
  | at x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.test.tsx:194:5
  | at x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.test.tsx:159:3
  | at Object.<anonymous> (x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.test.tsx:132:1)
  |  
 

<br class="Apple-interchange-newline">

The new time for expensive flaky tests is 21s:
Screen Shot 2022-10-25 at 11 52 34 AM

Cleaned up the jest errors when running tests:

Screen Shot 2022-10-24 at 3 06 33 PM

Screen Shot 2022-10-24 at 3 07 55 PM

Screen Shot 2022-10-24 at 10 22 35 PM

@YulNaumenko YulNaumenko self-assigned this Oct 22, 2022
@YulNaumenko YulNaumenko marked this pull request as ready for review October 24, 2022 02:10
@YulNaumenko YulNaumenko requested review from a team as code owners October 24, 2022 02:10
@YulNaumenko YulNaumenko added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 Team:Threat Hunting:Investigations Security Solution Investigations Team labels Oct 24, 2022
Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the flaky results are the same ones saw in main, so if buildkite likes it lgtm 👍

…st-143718' into security-solution-fix-skipped-test-143718
@YulNaumenko YulNaumenko requested a review from a team as a code owner October 25, 2022 04:31
Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unapproving until we figure out what's up with the body/index.test.tsx times

Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤩

Thank you for improving our tests.

@YulNaumenko
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.5MB 9.5MB +528.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 438 441 +3

Total ESLint disabled count

id before after diff
securitySolution 515 518 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Jest config: x-pack/plugins/security_solution/public/timelines
5 participants