-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fixed flaky Jest config: x-pack/plugins/security_solution/public/timelines #143824
[Security Solution] Fixed flaky Jest config: x-pack/plugins/security_solution/public/timelines #143824
Conversation
…solution/public/timelines
…st-143718' into security-solution-fix-skipped-test-143718
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the flaky results are the same ones saw in main, so if buildkite likes it lgtm 👍
…st-143718' into security-solution-fix-skipped-test-143718
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unapproving until we figure out what's up with the body/index.test.tsx times
x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤩
Thank you for improving our tests.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
Resolves #143718
The new time for expensive flaky tests is 21s:
Cleaned up the jest errors when running tests: