[index patterns] Fallback to id if title does not exist #14302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's also get a unit test so we're not burned by this again. |
|
Working on a forward port |
|
Nevermind, no forward port needed. Looks like it was lost in the backport of #12794. On the plus side the code is coincidentally the exact same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (5.6+) patterns sent to elasticsearch are pulling from the title field in a saved object. In prior versions of the kibana index, we pulled the pattern from the _id field. For older versions of .kibana that don't have a title field, we set title in memory to be equal to _id. We'll need a more robust versioning fix in the future.
Closes #14267