-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Adds button group to navigate to "All services" #142911
Merged
ogupte
merged 14 commits into
elastic:main
from
ogupte:apm-142084-service-groups-button-group-nav
Oct 30, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b2d6070
[APM] Adds button group to navigate to "All services" (#142084)
ogupte 3e2b38b
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 11e99e3
Adds button group legend, fixes spacing and translation IDs
ogupte 5ed803c
Merge branch 'main' into apm-142084-service-groups-button-group-nav
ogupte 69b605d
makes the button group part of the page template
ogupte 908feff
addresses feedback
ogupte 015ff12
Merge branch 'main' into apm-142084-service-groups-button-group-nav
ogupte 97e693a
Merge branch 'main' into apm-142084-service-groups-button-group-nav
ogupte ef3e2fa
addressed feedback:
ogupte b475f32
Merge branch 'main' into apm-142084-service-groups-button-group-nav
ogupte 6277761
fixes tests and deep links
ogupte b2f7543
change button group to single type
ogupte 0d02589
fixes type error
ogupte 59838b2
Merge branch 'main' into apm-142084-service-groups-button-group-nav
ogupte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
x-pack/plugins/apm/public/components/app/service_groups/service_groups_button_group.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
import { EuiButtonGroup } from '@elastic/eui'; | ||
import { i18n } from '@kbn/i18n'; | ||
import React from 'react'; | ||
import { useHistory } from 'react-router-dom'; | ||
import { ServiceGroupsTour } from './service_groups_tour'; | ||
import { useServiceGroupsTour } from './use_service_groups_tour'; | ||
|
||
const buttonGroupOptions = { | ||
allServices: { | ||
option: { | ||
id: 'allServices', | ||
label: i18n.translate('xpack.apm.serviceGroups.buttonGroup.allServices', { | ||
defaultMessage: 'All services', | ||
}), | ||
}, | ||
pathname: '/services', | ||
}, | ||
serviceGroups: { | ||
option: { | ||
id: 'serviceGroups', | ||
label: i18n.translate( | ||
'xpack.apm.serviceGroups.buttonGroup.serviceGroups', | ||
{ defaultMessage: 'Service groups' } | ||
), | ||
}, | ||
pathname: '/service-groups', | ||
}, | ||
}; | ||
|
||
type SelectedNavButton = keyof typeof buttonGroupOptions; | ||
|
||
export function ServiceGroupsButtonGroup({ | ||
selectedNavButton, | ||
}: { | ||
selectedNavButton: SelectedNavButton; | ||
}) { | ||
const history = useHistory(); | ||
const { tourEnabled, dismissTour } = useServiceGroupsTour('createGroup'); | ||
return ( | ||
<ServiceGroupsTour | ||
tourEnabled={tourEnabled} | ||
dismissTour={dismissTour} | ||
anchorPosition="leftUp" | ||
title={i18n.translate('xpack.apm.serviceGroups.tour.createGroups.title', { | ||
defaultMessage: 'Introducing service groups', | ||
})} | ||
content={i18n.translate( | ||
'xpack.apm.serviceGroups.tour.createGroups.content', | ||
{ | ||
defaultMessage: | ||
'Group services together to build curated inventory views that remove noise and simplify investigations across services. Groups are Kibana space-specific and available for any users with appropriate access.', | ||
} | ||
)} | ||
> | ||
<EuiButtonGroup | ||
color="primary" | ||
options={[ | ||
buttonGroupOptions.allServices.option, | ||
buttonGroupOptions.serviceGroups.option, | ||
]} | ||
idSelected={selectedNavButton as string} | ||
onChange={(id) => { | ||
const { pathname } = buttonGroupOptions[id as SelectedNavButton]; | ||
history.push({ pathname }); | ||
}} | ||
legend={i18n.translate('xpack.apm.servicesGroups.buttonGroup.legend', { | ||
defaultMessage: 'View all services or service groups', | ||
})} | ||
/> | ||
</ServiceGroupsTour> | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ogupte could this be removed instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, i'll remove it while working on alerts integration