Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Updates value list exceptions doc link #142909

Merged
merged 3 commits into from
Oct 12, 2022
Merged

[Security Solution] Updates value list exceptions doc link #142909

merged 3 commits into from
Oct 12, 2022

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Oct 6, 2022 •
edited by kibanamachine
Loading

Summary

Addresses #141373

Following doc link from here: elastic/security-docs#2471

Replaces the placeholder link with the actual doc URL that will be used

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Detection Rule Exceptions area Team:Detection Alerts Security Detection Alerts Area Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.5.0 labels Oct 6, 2022
@dplumlee dplumlee self-assigned this Oct 6, 2022
@dplumlee dplumlee requested a review from a team as a code owner October 6, 2022 19:16
@dplumlee dplumlee requested a review from joepeeples October 6, 2022 19:16
@dplumlee dplumlee added the release_note:skip Skip the PR/issue when compiling release notes label Oct 6, 2022
nkhristinin
nkhristinin approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!:)

@dplumlee dplumlee requested a review from a team as a code owner October 12, 2022 16:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 317 320 +3
securitySolution 3165 3168 +3
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 152.7KB 191.2KB +38.5KB
securitySolution 6.6MB 6.6MB +14.0B
total +38.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 367.2KB 367.3KB +89.0B
lists 3.6KB 3.7KB +50.0B
total +139.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

gchaps
gchaps approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @joepeeples approves, so does kibana-docs

@dplumlee dplumlee merged commit 987af1c into elastic:main Oct 12, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.5 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 142909

Questions ?

Please refer to the Backport tool documentation

@dplumlee dplumlee mentioned this pull request Oct 12, 2022
Merged
@dplumlee
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dplumlee added a commit to dplumlee/kibana that referenced this pull request Oct 12, 2022
@dplumlee
[Security Solution] Updates value list exceptions doc link (elastic#1…
94e0e71 
…42909)

(cherry picked from commit 987af1c)

# Conflicts:
#	packages/kbn-doc-links/src/get_doc_links.ts
#	packages/kbn-doc-links/src/types.ts
dplumlee added a commit that referenced this pull request Oct 12, 2022
@dplumlee
[Security Solution] Updates value list exceptions doc link (#142909) (#…
bb518ae 
…143240)

(cherry picked from commit 987af1c)

# Conflicts:
#	packages/kbn-doc-links/src/get_doc_links.ts
#	packages/kbn-doc-links/src/types.ts
@dplumlee dplumlee deleted the value-list-doc-link branch October 12, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

@gchaps gchaps gchaps approved these changes

@nkhristinin nkhristinin nkhristinin approved these changes

Assignees

@dplumlee dplumlee

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Detection Rule Exceptions area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dplumlee @kibana-ci @kibanamachine @nkhristinin @gchaps @joepeeples