-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Alerting] Rule run history displays success with a message when the rule status is warning #142645
[ResponseOps][Alerting] Rule run history displays success with a message when the rule status is warning #142645
Conversation
…:doakalexi/kibana into alerting/rule-run-history-matches-status
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial comments but overall looks good! I noticed that when I filter on the Warning
outcome and then sort by the Active Alerts
column, I get empty data:
With warning filter, sorted Active Alerts A-Z
Also noticed that when I search for "reported" in the message, I get warning + success, even though I have the warning filter applied. Looks like it is doing an OR and not an AND? @JiaweiWu Is this a known issue?
x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.ts
Outdated
Show resolved
Hide resolved
…on.ts Co-authored-by: Ying Mao <[email protected]>
…:doakalexi/kibana into alerting/rule-run-history-matches-status
@ymao1 thanks for the heads up, it's not been reported AFAIK but I will take a look edit: Looks like we forgot a parentheses, will create an issue (#142889) i.e. the query is |
...ui/public/application/sections/rule_details/components/rule_event_log_list_status_filter.tsx
Outdated
Show resolved
Hide resolved
...ctions_ui/public/application/sections/rule_details/components/rule_event_log_list_status.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested locally the rule execution results table (the one on the detection rule details page). Everything works as expected.
...ui/public/application/sections/rule_details/components/rule_event_log_list_status_filter.tsx
Outdated
Show resolved
Hide resolved
…:doakalexi/kibana into alerting/rule-run-history-matches-status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
tested locally, works as expected.
x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one comment about unit tests but everything looks great and works as expected!
…un-history-matches-status
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Resolves #129120
Summary
Adds a new field to the event log
kibana.alerting.outcome
that will allow us to set the warning status.Checklist
To verify
To verify that filtering still works correctly:
yarn es snapshot --license trial -E path.data=<data_path>
on a different branchTo verify that warning shows up:
x-pack/plugins/alerting/server/lib/rule_execution_status.ts