You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a datasources folder and moved the two datasources inside
Renamed the "textBasedLanguages" datasource to textBased (also renaming of types)
Renamed the "indexPattern" datasource to formBased (also renaming of types)
Note1: I havent renamed css classes or data subjects. We could do it on a followup PR
Note2: If you have SOs with the text based language will fail because this PR also changes the id of this datasource. This is ok as we are introducing text based languages in Lens on this minor.
Note 3: This PR introduces a migration script.
How to test
Test that old by value and by reference Lens visualizations work as expected (ensure that migrations have run)
Test that new Lens visualizations work as expected for the formBased datasource
Test that new Lens visualizations work as expected for textBased datasource
The functional tests run successfully which is a great indicator that everything works as expected but I would appreciate a manual testing to ensure that everything works fine.
@elastic/security-solution can you help me with these test failures? I don't get why they started failing today after I merged with main. I don't see how they are relevant with my changes but maybe I am wrong, I would appreciate some help here! Thanx
@stratoula Checking the CI for the security solution failure, it looks like you updated this in some places where it shouldn't be updated because it's saved objects running through migration:
I think it's x-pack/plugins/security_solution/server/lib/risk_score/prebuilt_saved_objects/saved_object/host_risk_score_dashboards.ts and x-pack/plugins/security_solution/server/lib/risk_score/prebuilt_saved_objects/saved_object/user_risk_score_dashboards.ts
[job][logs] Security Solution Tests #2 / Alerts detection rules table auto-refresh should disable auto refresh when any rule selected and enable it after rules unselected
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stratoula
added
technical debt
Summary
Closes #137723
This PR does the following things:
Note1: I havent renamed css classes or data subjects. We could do it on a followup PR
Note2: If you have SOs with the text based language will fail because this PR also changes the id of this datasource. This is ok as we are introducing text based languages in Lens on this minor.
Note 3: This PR introduces a migration script.
How to test
The functional tests run successfully which is a great indicator that everything works as expected but I would appreciate a manual testing to ensure that everything works fine.