Add node scripts/yarn_deduplicate #142531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
Team:Operations
|
I looked into adding autocommits but it's messy, workflow would look something like:
|
|
Pinging @elastic/kibana-operations (Team:Operations) |
…ntegration/test_suites/task_manager/task_management·ts - task_manager scheduling and running tasks should disable and reenable task and not run it when runSoon = false (elastic#142749) * Unskipping test * Adding some console logs * Comparing strings * Setting date beforehand * Comparing against disabled task * Reverting unnecessary changes * Cleanup Co-authored-by: Kibana Machine <[email protected]>
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
jbudz
commented
Oct 10, 2022
| @@ -709,7 +709,7 @@ export default function ({ getService }: FtrProviderContext) { | |||
| const task = await currentTask(scheduledTask.id); | |||
|
|
|||
| expect(task.enabled).to.eql(true); | |||
| expect(Date.parse(task.scheduledAt)).to.eql(Date.parse(scheduledTask.scheduledAt)); | |||
| expect(Date.parse(task.scheduledAt)).to.eql(Date.parse(disabledTask.scheduledAt)); | |||
There was a problem hiding this comment.
ignore this, sorry about the ping. looks like I messed up the merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a wrapper around
yarn-deduplicate, excluding to-be-triaged node_modules that break CI. Can be run withnode scripts/yarn_deduplicateand is included in the bootstrap check on CI.Closes #125712