[index patterns] Don't attempt to wrap Boom errors #14253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoboat
approved these changes
Oct 3, 2017
kimjoar
force-pushed
the
index-patterns/do-not-wrap-boom-errors
branch
from
6dfc3fb to
a45e43c
Compare
kimjoar
added a commit
to kimjoar/kibana
that referenced
this pull request
Oct 3, 2017
kimjoar
added a commit
to kimjoar/kibana
that referenced
this pull request
Oct 3, 2017
kimjoar
added a commit
that referenced
this pull request
Oct 3, 2017
kimjoar
added a commit
that referenced
this pull request
Oct 3, 2017
kimjoar
added a commit
to kimjoar/kibana
that referenced
this pull request
Oct 4, 2017
kimjoar
added a commit
that referenced
this pull request
Oct 4, 2017
|
@kjbekkelund Does this actually fix #14021? |
|
@epixa I haven't been able to reproduce it, but I expect not. It will help debugging this though. If you have other ideas for debugging while waiting for this to get in, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
Boom.wrapthrows if it's already a Boom error and either status or message is specified (https://github.com/hapijs/boom/blob/master/lib/index.js#L96). Looks like there's a couple of people that have hit this problem in #14021.Boom 2.8.0 in https://github.com/elastic/kibana/blob/v5.5.0/package.json#L109 and Boom 5.2.0 in
https://github.com/elastic/kibana/blob/v5.6.2/package.json#L108, so maybe some breaking change there that might cause this to throw now(?)