Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Api tests for ml/results/anomaly_search #142454

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Oct 3, 2022

Creates and runs a job and then attempts to load results from a valid and invalid space.

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0 labels Oct 3, 2022
@jgowdyelastic jgowdyelastic self-assigned this Oct 3, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 3, 2022 10:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

@jgowdyelastic jgowdyelastic enabled auto-merge (squash) October 3, 2022 11:39
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit bea4228 into elastic:main Oct 3, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 3, 2022
* [ML] Api tests for ml/results/anomaly_search

* changes based on review

(cherry picked from commit bea4228)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 3, 2022
* [ML] Api tests for ml/results/anomaly_search

* changes based on review

(cherry picked from commit bea4228)

Co-authored-by: James Gowdy <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
* [ML] Api tests for ml/results/anomaly_search

* changes based on review
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
* [ML] Api tests for ml/results/anomaly_search

* changes based on review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants