[Unified search] Fixes the problem with the button popover buttons on DSL filters #142402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:Unified search
jloleysens
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Thanks for this fix @stratoula !
I tested locally and this does work, but I think we can make use of the isolate rule to lift all changes to one place.
I tested on Firefox and this issue does not exist there. I couldn't quite figure out why this is happening because we are setting overflow: hidden on the relative ancestor 😅 . Great job finding the solution with stacking context!
src/plugins/unified_search/public/filter_bar/filter_editor/filter_editor.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2022
… DSL filters (elastic#142402) * [Unified search] Fixes the problem with the button popover buttons on DSL filters * Add comment * Apply comments (cherry picked from commit fe2210b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2022
… DSL filters (#142402) (#142458) * [Unified search] Fixes the problem with the button popover buttons on DSL filters * Add comment * Apply comments (cherry picked from commit fe2210b) Co-authored-by: Stratoula Kalafateli <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
… DSL filters (elastic#142402) * [Unified search] Fixes the problem with the button popover buttons on DSL filters * Add comment * Apply comments
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
… DSL filters (elastic#142402) * [Unified search] Fixes the problem with the button popover buttons on DSL filters * Add comment * Apply comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #142211
By adding
position: relativeon the buttons, make them responsive and fixes the bug mentioned on the issue.