[Fleet] Bulk action refactor and small fixes #142299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
changed the title
juliaElastic
added
the
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
criamico
approved these changes
Sep 30, 2022
1 task
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
juliaElastic
added
the
backport:prev-minor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2022
* refactor to report errors in agent update for all actions * fixed tests * fixed types * refactor to reduce duplication * fixed test * fix for cypress test * passing error reason Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit f8a9027)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2022
* refactor to report errors in agent update for all actions * fixed tests * fixed types * refactor to reduce duplication * fixed test * fix for cypress test * passing error reason Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit f8a9027) Co-authored-by: Julia Bardi <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* refactor to report errors in agent update for all actions * fixed tests * fixed types * refactor to reduce duplication * fixed test * fix for cypress test * passing error reason Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* refactor to report errors in agent update for all actions * fixed tests * fixed types * refactor to reduce duplication * fixed test * fix for cypress test * passing error reason Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #141567
Refactor to report errors in agent update for all actions.
Refactor to reduce duplication around writing out errors as action results.
Fix for action status ack calculation: sometimes the cardinality agg is not precise (after 40k) and returns a bigger number than the doc count, taking the minimum in this case.
Before:
After:
Fix for an edge case in update tags: when adding and removing a tag quickly on a large agent selection, the remove tag request was not correct.
tags_fix.mov
Checklist