Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds content on ad hoc data view #142290

Merged
merged 6 commits into from
Oct 10, 2022

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Sep 29, 2022

Summary

This PR adds content when users click Use without saving in the Create a data view form.

@gchaps gchaps added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0 labels Sep 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@github-actions
Copy link
Contributor

Documentation preview:

@gchaps gchaps requested review from KOTungseth and kertal September 30, 2022 17:19
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change, but no big deal. LGTM!

docs/concepts/data-views.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@ninoslavmiskovic ninoslavmiskovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gchaps gchaps merged commit 411c261 into elastic:main Oct 10, 2022
@gchaps gchaps deleted the docs/ad-hoc-data-views branch October 10, 2022 16:58
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2022
* [DOCS] Adds content on ad hoc data view

* [DOCS] Breaks data into two steps

* Update docs/concepts/data-views.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Tweaks message re: unsaved data views

Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 411c261)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2022
* [DOCS] Adds content on ad hoc data view

* [DOCS] Breaks data into two steps

* Update docs/concepts/data-views.asciidoc

Co-authored-by: Kaarina Tungseth <[email protected]>

* [DOCS] Tweaks message re: unsaved data views

Co-authored-by: Kaarina Tungseth <[email protected]>
(cherry picked from commit 411c261)

Co-authored-by: gchaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants