-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shared UX] Markdown Component #142228
[Shared UX] Markdown Component #142228
Conversation
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
Adding openInNewTab support based on Chandler's work in https://codesandbox.io/s/relaxed-yalow-hy69r4?file=/demo.js in commit 66ed116 |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @rshen91 |
Summary
Relating to #141166 taking considerations from instances of markdown etc in Kibana for this Shared UX Markdown component using
EuiMarkdownEditor
andEuiMarkdownFormat
.For places that previously used
MarkdownSimple
both implementations are supported:which was previously:
If readOnly is not passed, then the Markdown component will be passed as
EuiMarkdownEditor
.openLinksInNewTab
is removed due to lack of support in Github Flavored Markdown but workaround from @chandlerprall implemented in commit 66ed116Checklist
Delete any items that are not applicable to this PR.