Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix bug with fields.yml not defined, add jest tests for new transform installation mechanism in Fleet #142159

Merged
merged 5 commits into from
Oct 5, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Sep 28, 2022

Summary

Follow up of #140046. This PR adds jest tests for the new transform installation mechanism in Fleet. It also fixes a bug with when fields.yml or mappings are not defined.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 28, 2022
@qn895 qn895 requested review from hop-dev and kpollich September 28, 2022 20:47
@qn895 qn895 self-assigned this Sep 28, 2022
@qn895 qn895 requested a review from a team as a code owner September 28, 2022 20:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@qn895
Copy link
Member Author

qn895 commented Oct 3, 2022

@elasticmachine merge upstream

@nchaulet nchaulet self-requested a review October 3, 2022 16:44
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the most familiar with that feature but tests looks good to me 🚀

@qn895 qn895 closed this Oct 4, 2022
@qn895 qn895 reopened this Oct 4, 2022
@qn895
Copy link
Member Author

qn895 commented Oct 4, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
fleet 62 63 +1

Total ESLint disabled count

id before after diff
fleet 70 71 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895
Copy link
Member Author

qn895 commented Oct 5, 2022

@elasticmachine merge upstream

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these tests and the fix, looks good to me 🚀

Kyle is on leave this week so won't be able to review.

@qn895 qn895 merged commit a3e2af4 into elastic:main Oct 5, 2022
@qn895 qn895 deleted the ml-fleet-transform-jest-tests branch October 5, 2022 14:21
@qn895 qn895 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.6.0 labels Oct 5, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
…sform installation mechanism in Fleet (elastic#142159)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit a3e2af4)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022
…sform installation mechanism in Fleet (#142159) (#142754)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit a3e2af4)

Co-authored-by: Quynh Nguyen (Quinn) <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
…sform installation mechanism in Fleet (elastic#142159)

Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
…sform installation mechanism in Fleet (elastic#142159)

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) :ml release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants