-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] [@kbn/tinymath] Add new defaults function #142087
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and works as expected
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
* ✨ Add new defaults function * ✨ Add new defaults function * 📝 Rewrite the doc Co-authored-by: Joe Reuter <[email protected]>
* ✨ Add new defaults function * ✨ Add new defaults function * 📝 Rewrite the doc Co-authored-by: Joe Reuter <[email protected]>
Summary
Closes #140829
This PR introduces a new
defaults
function, useful to gracefully fallback from missing values.I'm not really super happy about the doc here, as there's no other mention of
null
in any other tinymath function in the doc. 🤔The new function has been documented also on the Lens Formula side.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers