[APM] Hash service name/environment for APM per_service telemetry #141685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basepi
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:APM) |
basepi
changed the title
basepi
changed the title
dgieselaar
approved these changes
Sep 23, 2022
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2022
…astic#141685) * Hash service name/environment for per_service telemetry * Fix typing and reorder service name/env Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 90b9afd)
This was referenced Sep 26, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2022
…astic#141685) * Hash service name/environment for per_service telemetry * Fix typing and reorder service name/env Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 90b9afd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2022
…41685) (#141822) * Hash service name/environment for per_service telemetry * Fix typing and reorder service name/env Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 90b9afd) Co-authored-by: Colton Myers <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2022
…41685) (#141821) * Hash service name/environment for per_service telemetry * Fix typing and reorder service name/env Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 90b9afd) Co-authored-by: Colton Myers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hash the service names and service environments for per_service telemetry. There's a small risk of there being identifiers in these fields that we don't want to have in our telemetry cluster, and these fields are only collected as unique identifiers for the data -- we don't need them raw. Hashing is safer.
Checklist
No checklist items were applicable
For maintainers
Ref #137216