Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Files] Dispose of subscriptions on unmount #141597

Merged
merged 3 commits into from
Sep 26, 2022
Merged

[Files] Dispose of subscriptions on unmount #141597

merged 3 commits into from
Sep 26, 2022

Conversation

jloleysens
Copy link
Contributor

Summary

  • Adds a dispose method to the upload state class
  • Calls dispose on component unmount

@jloleysens jloleysens added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:AppServicesUx v8.5.0 feature:Files labels Sep 23, 2022
@jloleysens jloleysens requested a review from Dosant September 23, 2022 10:25
@jloleysens jloleysens requested a review from a team as a code owner September 23, 2022 10:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

Dosant
Dosant approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
files 152.0KB 152.2KB +173.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit add2a12 into elastic:main Sep 26, 2022
@jloleysens jloleysens deleted the files-file-upload-unsubscribe branch September 26, 2022 12:25
@kibanamachine kibanamachine mentioned this pull request Sep 26, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Sep 26, 2022
@jloleysens
[Files] Dispose of subscriptions on unmount (#141597)
04d8d27 
* added dispose logic to state

* hook dispose logic in to component lifecycle

(cherry picked from commit add2a12)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Sep 26, 2022
@kibanamachine @jloleysens
[Files] Dispose of subscriptions on unmount (#141597) (#141762)
593bc33 
* added dispose logic to state

* hook dispose logic in to component lifecycle

(cherry picked from commit add2a12)

Co-authored-by: Jean-Louis Leysens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed feature:Files release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jloleysens @elasticmachine @kibana-ci @kibanamachine @Dosant