[Fleet] updated openapi for bulk action responses #141566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
criamico
approved these changes
Sep 23, 2022
| error?: string; | ||
| } | ||
| >; | ||
| export type PostBulkAgentUpgradeResponse = |
There was a problem hiding this comment.
nit: Since this type is repeated several times on this file, it could make sense to create a type for it and reassign wherever is used? Something like this:
type AgentUpgradeResponse = | Record<
Agent['id'],
{
success: boolean;
error?: string;
}
>
| { actionId: string };
In the case you like the suggestion feel free to pick a better name!
There was a problem hiding this comment.
yes, I just did that!
juliaElastic
force-pushed
the
bulk-actions-openapi
branch
from
e59be68 to
b4d17f1
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2022
(cherry picked from commit 76fe2e3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 23, 2022
* main: [Files] Use self destruct flag in upload component (elastic#141366) [Synthetics] Unskip certs flaky test (elastic#141423) updated openapi for bulk action responses (elastic#141566) Fix page responsiveness for smaller screen sizes (elastic#141471)
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2022
(cherry picked from commit 76fe2e3) Co-authored-by: Julia Bardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated OpenAPI spec to reflect changes made for #141567
/bulk_reassign, /bulk_unenroll, /bulk_upgrade, /bulk_update_tagscan return now anactionIdinstead of object with agent ids, in case of async execution.Checklist