[Fleet] Support migrating from integration type package to input type package #141472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
commented
Sep 22, 2022
| @@ -106,4 +106,4 @@ const addDatasetVarIfNotPresent = (vars?: RegistryVarsEntry[]): RegistryVarsEntr | |||
| const createDefaultDatasetName = ( | |||
| packageInfo: PackageInfo, | |||
| policyTemplate: RegistryPolicyInputOnlyTemplate | |||
| ): string => packageInfo.name + '.' + policyTemplate.type; | |||
| ): string => packageInfo.name + '.' + policyTemplate.name; | |||
There was a problem hiding this comment.
During testing I found name to be a lot more descriptive here than type, and matches how integration packages tend to work
hop-dev
commented
Sep 22, 2022
| if (cache) setPackageInfo({ name, version, packageInfo }); | ||
| // only cache registry pkg info for integration pkgs because | ||
| // input type packages must get their pkg info from the archive | ||
| if (packageInfo.type === 'integration') setPackageInfo({ name, version, packageInfo }); |
There was a problem hiding this comment.
While investigating a bug where the cache parameter wasn't passed, I decided it was more explicit to have this function know that we never cache registry info for input packages (because we have to get the info from the archive)
hop-dev
added
release_note:skip
hop-dev
changed the title
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
approved these changes
Sep 22, 2022
hop-dev
force-pushed
the
137751-input-pkg-migration
branch
from
0d39c5f to
4292597
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2022
… package (elastic#141472) * it works * neaten * test failing * fix test pkgs * fix input to policy template matching * move to zip packages * never cache registry info for input packages * remove .only * fix dataset name in unit test (cherry picked from commit a61506b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2022
… package (#141472) (#141578) * it works * neaten * test failing * fix test pkgs * fix input to policy template matching * move to zip packages * never cache registry info for input packages * remove .only * fix dataset name in unit test (cherry picked from commit a61506b) Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #137751
Minor fixes and api tests to support migrating a package from type "integration" to type "input".
How to test:
Checklist
Delete any items that are not applicable to this PR.