-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Quickfunction help #141399
[Lens] Quickfunction help #141399
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...gins/lens/public/indexpattern_datasource/operations/definitions/calculations/differences.tsx
Outdated
Show resolved
Hide resolved
Good suggestion @mbondyra , I'm not sure about all the descriptions. Some of them are from the original spacetime PR, some of them I came up with on the spot because they were missing. @KOTungseth could you take a look too? |
Thank you so much for opening this PR! Here are my recommended changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still change The change, or difference, between the values in subsequent intervals.
to The change between the values in subsequent intervals.
but apart from it looks fine.
@elasticmachine merge upstream |
…definitions/calculations/differences.tsx Co-authored-by: Marta Bondyra <[email protected]>
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
@flash1293: I'm a little late to the party on this one, but is there any chance we could switch the |
No problem, opened a PR for this: #142623 |
for auditing purposes, I referenced this issue in a bug-fix by mistake. |
Adds help popover for quickfunctions:
For every function list, the popover shows the functions which are available as well.
Full list of descriptions: