[APM] Add API tests for storage explorer #141391
Conversation
gbamparop
added
Team:APM
|
Pinging @elastic/apm-ui (Team:APM) |
| const transactionStats = body.processorEventStats.find( | ||
| ({ processorEvent }) => processorEvent === ProcessorEvent.transaction | ||
| ); |
There was a problem hiding this comment.
I think you could use keyBy to create an object per processorEvent. With that, you won't need to use find for each type.
| const transactionStats = body.processorEventStats.find( | |
| ({ processorEvent }) => processorEvent === ProcessorEvent.transaction | |
| ); | |
| const statsGroupedByEvent = keyBy(body.processorEventStats, 'processorEvent') | |
| const transactionStats = statsGroupedByEvent[ProcessorEvent.transaction] | |
| const spanStats = statsGroupedByEvent[ProcessorEvent.span] | |
| .... |
There was a problem hiding this comment.
Makes sense, added it in b8679d2
| const goServiceStats = body.serviceStatistics.find( | ||
| ({ serviceName }) => serviceName === 'opbeans-go' | ||
| ); |
|
|
||
| expect(status).to.be(200); | ||
| expect(body.numberOfServices).to.be(2); | ||
| expect(Math.round(body.tracesPerMinute)).to.be(2); |
There was a problem hiding this comment.
you could use https://github.com/cauemarcondes/kibana/blob/apm-labs-telemetry/x-pack/test/apm_api_integration/utils.ts#L12:L12. but it's up to you.
There was a problem hiding this comment.
Updated in b8679d2
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
* Add API tests for storage explorer (cherry picked from commit 4137fb3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* Add API tests for storage explorer (cherry picked from commit 4137fb3) Co-authored-by: Giorgos Bamparopoulos <[email protected]>
Add API tests for storage explorer.
Related to #140199