Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] fix ml pipeline name help text #141311

Conversation

TattdCodeMonkey
Copy link
Contributor

Summary

Reverted the help text to use ml-inference- as the name prefix since we decided to not include the index name in the pipeline name. This will make it easier to re-use pipelines in future releases.
image

Reverted the help text to use `ml-inference-` as the name prefix since
we decided to not include the index name in the pipeline name. This will
make it easier to re-use pipelines in future releases.
@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:EnterpriseSearch v8.5.0 v8.6.0 labels Sep 21, 2022
@TattdCodeMonkey TattdCodeMonkey requested a review from a team September 21, 2022 20:52
Copy link

@jgr jgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@TattdCodeMonkey
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #19 / alerting api integration spaces only Alerting disable should handle disable rule request appropriately

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB -45.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit 2eb17e8 into elastic:main Sep 21, 2022
kibanamachine pushed a commit that referenced this pull request Sep 21, 2022
Reverted the help text to use `ml-inference-` as the name prefix since
we decided to not include the index name in the pipeline name. This will
make it easier to re-use pipelines in future releases.

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2eb17e8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/es/fix-ml-inference-pipeline-name-helptext branch September 22, 2022 14:16
kibanamachine added a commit that referenced this pull request Sep 22, 2022
Reverted the help text to use `ml-inference-` as the name prefix since
we decided to not include the index name in the pipeline name. This will
make it easier to re-use pipelines in future releases.

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2eb17e8)

Co-authored-by: Rodney Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants