-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps] Add kibana.alert.time_range field to Alert-As-Data mappings and populate it #141309
[ResponseOps] Add kibana.alert.time_range field to Alert-As-Data mappings and populate it #141309
Conversation
…ings and populate it
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just so FANCY!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simianhacke, don't we need to add the new field in the Rule Registry README file? |
I am also not able to see the field locally, I also don't see any |
@fkanout Because |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
I tried it locally again with I was trying to check the visualization but I didn't find a way to set |
I have the same question as @maryam-saeidi. How to provide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maryam-saeidi, as Chris said |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for APM
@maryam-saeidi @benakansara Lens date histogram only works with |
…ings and populate it (elastic#141309) * [ResponseOps] Add kibana.alert.time_range field to Alert-As-Data mappings and populate it * Fixing snapshots to match new reality * Removing the lte (end of range) for active alerts. * Fixing expected resutls for mapping test * fixing tests * updating readme * Fixing field name in README Co-authored-by: Faisal Kanout <[email protected]>
…ings and populate it (elastic#141309) * [ResponseOps] Add kibana.alert.time_range field to Alert-As-Data mappings and populate it * Fixing snapshots to match new reality * Removing the lte (end of range) for active alerts. * Fixing expected resutls for mapping test * fixing tests * updating readme * Fixing field name in README Co-authored-by: Faisal Kanout <[email protected]>
Summary
This PR adds the field
ALERT_TIME_RANGE
(akakibana.alert.time_range
) of typedata_range
to the Alert As Data technical fields. This will allow solutions to draw timelines of alerts on charts by running adate_histogram
on theALERT_TIME_RANGE
field. The results is that thedate_histogram
will create a bucket (with onedoc_count
per alert) for each bucket that theALERT_TIME_RANGE
field spans. In the example below I have one rule generating 13 alerts which are active for 8 minutes, I then indexed 10 more hosts and the number of alerts jumps to 23.Ultimately this field will be used for render this chart on Actionable Observability
Caveats
hard_bounds
to the same extents as therange
query otherwise thedate_histogram
will draw every bucket for the entire range. For open ranges OR active alerts in our use case, without thehard_bounds
you will end up with atoo many buckets
exception.Checklist
Delete any items that are not applicable to this PR.